<ATP SATAIII SSD> Add additional model name to the database

[ATPElectronics]

Hi, please kindly update the database with the attached files.
Thank you!

Attachments: drivedb and the patch files

[Christian Franke]

This is apparently an enhancement of ticket #1822.

Please provide a smartctl -x -a sample output of a drive which matches the newly added I-Temp pattern.

In future submissions, please

• don't post the full drivedb.h file,
• provide patches in unified diff format (diff -u drivedb.h.old drivedb.h), and
• always provide a sample output of at least one newly added drive model.

[ATPElectronics]

Updated attachment, thank you!

[Christian Franke]

We do not add entries for each new drive series if the SMART Attributes are similar.

A closer look shows that the new entry ATP SATA III SSDs is very similar to the existing entry ATP SATA III aMLC M.2 2242/80 Embedded SSDs and some drives (e.g. ATP I-Temp M.2 2242) are matched by the patterns of both entries.

Please provide one combined entry or explain why this is not possible.

[ATPElectronics]

Thanks for the reply, based on the examples you mentioned:

ATP SATA III SSDs
The product name matching condition for this entry is ATP (AF|FT|FA|I-Temp).* ATP SATA III aMLC M.2 2242/80 Embedded SSDs

ATP I-Temp M.2 2242
The product name matching condition for this entry is ATP I-Temp M\.2 22(42|80).
Since we have another product with the name ATP I-Temp. SATA III M.2 2242, which includes an additional "." after I-Temp and contains "SATA III", none of the above three conditions can correctly match this product.

Therefore, in the Drivedb.h.patch file, we modified the string under "ATP SATA III SSDs" by adding "ATP (AF|FT|FA|I-Temp).*" to ensure proper matching.

However, we did not add a new entry for the "ATP I-Temp.*" string and its corresponding SMART attributes in drivedb.h.

Are you suggesting that we should manually add the entry containing "ATP I-Temp.*" and its associated SMART attributes to the drivedb.h file before uploading it to the platform?

[Christian Franke]

Pattern from existing entry​ ATP SATA III aMLC M.2 2242/80 Embedded SSD:
ATP I-Temp M\\.2 22(42|80)

Pattern from new entry​ ATP SATA III SSDs:
ATP (AF|FT|FA|I-Temp).*

The identify strings ATP I-Temp M.2 2242 and ATP I-Temp M.2 2280 mentioned in the comment of the existing entry also match the regex of the new entry.

I would suggest to replace the existing entry with the new ATP SATA III SSDs instead of adding a new one.

If this is not possible, please explain and make the regex of the new entry more restrictive, for example
ATP (AF|FT|FA|I-Temp\. SATA III M\.2 22).*

[ATPElectronics]

Thanks for your suggestion, existing entry was updated accordingly.

[Christian Franke]

Sorry, no. The mentioned existing entry ATP SATA III aMLC M.2 2242/80 Embedded SSDs is still present in the drivedb.2.h​ provided above.

ATP I-Temp M.2 2242 etc. are still matched by both entries. You could test this with:

$ /usr/sbin/smartctl -B drivedb.2.h -P showall 'ATP I-Temp M.2 2242'
Drive found in smartmontools Database.  Drive identity strings:
MODEL:              ATP I-Temp M.2 2242
FIRMWARE:           (any)
match smartmontools Drive Database entry:
MODEL REGEXP:       ATP I-Temp M\.2 22(42|80)
FIRMWARE REGEXP:    .*
MODEL FAMILY:       ATP SATA III aMLC M.2 2242/80 Embedded SSDs
ATTRIBUTE OPTIONS:  001 Raw_Read_Error_Count
                    ...
                    249 Spare_Block_Remaining

and match these additional entries:
MODEL REGEXP:       ATP (AF|FT|FA|I-Temp|I-Temp.SATA III M.2 22).*
FIRMWARE REGEXP:    .*
MODEL FAMILY:       ATP SATA III SSDs
ATTRIBUTE OPTIONS:  001 Raw_Read_Error_Count
                    ...
                    249 Spare_Block_Remaining

Again: The new entry ATP SATA III SSDs should replace the existing entry ATP SATA III aMLC M.2 2242/80 Embedded SSDs if possible.

BTW, the regex of the new entry now also contains the never used part |I-Temp.SATA III M.2 22) because this is already covered by |I-Temp| due to the trailing .*.

[ATPElectronics]

Thanks for the reply...

The target model name for this application is to have a newer product "ATP I-Temp. SATA III M.2 2242", which's name is similar to older one but it should apply to our newer SMART attributes in group "ATP (AF|FT|FA|I-Temp).*".

So could we roll back to the first submit (ie. drivedb.h​ uploaded on Jan 5, 2025)?
We have tested it, it only matchesd one entry:

# smartctl -B drivedb.h -P showall 'ATP I-Temp'
Drive found in smartmontools Database. Drive identity strings:
MODEL: ATP I-Temp
FIRMWARE: (any)
match smartmontools Drive Database entry:
MODEL REGEXP: ATP (AF|FT|FA|I-Temp).*
FIRMWARE REGEXP: .*
MODEL FAMILY: ATP SATA III SSDs
ATTRIBUTE OPTIONS: 001 Raw_Read_Error_Count

014 Device_Raw_Capacity

...

---

# smartctl -B drivedb.h -P showall 'ATP I-Temp. SATA III M.2 2242'
Drive found in smartmontools Database. Drive identity strings:
MODEL: ATP I-Temp. SATA III M.2 2242
FIRMWARE: (any)
match smartmontools Drive Database entry:
MODEL REGEXP: ATP (AF|FT|FA|I-Temp).*
FIRMWARE REGEXP: .*
MODEL FAMILY: ATP SATA III SSDs
ATTRIBUTE OPTIONS: 001 Raw_Read_Error_Count
...

Thanks again!