Opened 2 months ago

Closed 5 weeks ago

#1877 closed enhancement (fixed)

Regex adjustment for Micron 5300 MAX (MTFDDAK1T9TDT)

Reported by: Robin Owned by: Christian Franke
Priority: minor Milestone: Release 7.5
Component: drivedb Version: 7.3
Keywords: ssd Cc: Robin

Description (last modified by Robin)

The regex for Micron 5300 MAX needs to be adjusted.

It is currently:
"Micron_5300(HC)?_MTFDDA[KV](240|480|960|1T9|3T8|7T6)TD[ST]"
and it needs to be:
"(Micron_5300)?(_|HC_)?MTFDDA[KV](240|480|960|1T9|3T8|7T6)TD[ST]"

Attachments (1)

smartctl-micron-5300-max.txt (12.9 KB ) - added by Robin 2 months ago.

Download all attachments as: .zip

Change History (9)

by Robin, 2 months ago

comment:1 by Christian Franke, 2 months ago

Keywords: ssd added
Milestone: Release 7.5unscheduled
Type: defectenhancement

This would no longer match Micron_5300_... without HC.

Fix:
"(Micron_5300(HC)?_)?MTFDDA[KV](240|480|960|1T9|3T8|7T6)TD[ST]"

PS: Please don't set a milestone in future submissions.

comment:2 by Christian Franke, 2 months ago

Summary: Regex adjustment for Micron 5300 MAXRegex adjustment for Micron 5300 MAX (MTFDDAK1T9TDT)

comment:3 by Robin, 2 months ago

Description: modified (diff)

comment:4 by Robin, 2 months ago

I updated the original ticket with a more inclusive regex. You can see that it matches here: https://regex101.com/r/vOvjwq/1

comment:5 by Christian Franke, 2 months ago

This variant also matches _ and HC_ prefix but should not:
https://regex101.com/r/9LoZb8/1
Therefore I prefer:
https://regex101.com/r/HHFTGX/1

comment:6 by Robin, 2 months ago

I'd be happy to go with your preference!

comment:7 by Christian Franke, 5 weeks ago

Milestone: unscheduledRelease 7.5
Owner: set to Christian Franke
Status: newaccepted

comment:8 by Christian Franke, 5 weeks ago

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.