Opened 7 years ago

Closed 7 years ago

Last modified 16 months ago

#874 closed patch (fixed)

SK hynix SC210, SC300, SC308, SC313 HFS256G32TNF-N3A0A

Reported by: Brij Kishore Rai Owned by:
Priority: minor Milestone: Release 6.6
Component: drivedb Version: 6.5
Keywords: Cc:

Description

Hello Smartctl Drive Database Team,

I found that my companies SSD drive (Project Name: SC313) has some attribute with different definition then default so I created a new entry for them. Please find attached my modified drivedb.h and output file.

Please update the current database.

Thanks,
Brij

Attachments (9)

smartctl-SK hynix SC313 HFS256G32TNF-N3A0A.txt​ (19.1 KB ) - added by Brij Kishore Rai 7 years ago.
Updated Database file
smartctl-HFS500G32TND-N1A2A.txt​ (5.3 KB ) - added by Brij Kishore Rai 7 years ago.
SC308 log
smartctl-SKhynix SC300 HFS256G32MND-3210A.txt​ (5.0 KB ) - added by Brij Kishore Rai 7 years ago.
SC300 log
drivedb.2.h​ (159.9 KB ) - added by Brij Kishore Rai 7 years ago.
Updated Database file
drivedb.3.h​ (159.9 KB ) - added by Brij Kishore Rai 7 years ago.
Updated Database file
drivedb.h​ (159.9 KB ) - added by Brij Kishore Rai 7 years ago.
Updated Database file
SC313_with_4490.txt​ (6.2 KB ) - added by Brij Kishore Rai 7 years ago.
output with r4490
SC313_with_patch.txt​ (6.2 KB ) - added by Brij Kishore Rai 7 years ago.
Output with applied patch
drivedb.h.patch​ (1.6 KB ) - added by Brij Kishore Rai 7 years ago.
drivedb.h r4490 patch

Download all attachments as: .zip

Change History (22)

by Brij Kishore Rai, 7 years ago

Attachment: smartctl-SK hynix SC313 HFS256G32TNF-N3A0A.txt​ added

Updated Database file

comment:1 by Christian Franke, 7 years ago

Component: all → drivedb
Keywords: SK hynix removed
Milestone: → Release 6.6
Type: defect → enhancement

comment:2 by Christian Franke, 7 years ago

Thanks.

I found that my companies SSD drive ...

Could you possibly also provide info or patches for other SK hynix SSD series?

For example SC210 (ticket #724) or SC308 (ticket #792).

comment:3 by Brij Kishore Rai, 7 years ago

Hi Chris,

I was able to find SC210 (ticket #724), SC300 & SC308(ticket #792) drive and it's SMART implementation details.

Uploading the updated database file & tested logs. Patch is on top of smartctl 6.6 2017-08-08 r4433 build.

Thanks,
Brij

by Brij Kishore Rai, 7 years ago

Attachment: smartctl-HFS500G32TND-N1A2A.txt​ added

SC308 log

by Brij Kishore Rai, 7 years ago

Attachment: smartctl-SKhynix SC300 HFS256G32MND-3210A.txt​ added

SC300 log

by Brij Kishore Rai, 7 years ago

Attachment: drivedb.2.h​ added

Updated Database file

by Brij Kishore Rai, 7 years ago

Attachment: drivedb.3.h​ added

Updated Database file

by Brij Kishore Rai, 7 years ago

Attachment: drivedb.h​ added

Updated Database file

comment:4 by Alex Samorukov, 7 years ago

Resolution: → fixed
Status: new → closed

Done, in r4451, thank you.

comment:5 by Christian Franke, 7 years ago

Merged in r4490.

comment:6 by Brij Kishore Rai, 7 years ago

Hi Chris,

I tested the updated database file and found that it didn't work as per my expectation.

Please refer

  1. the output with r4490 and with my patch.
    1. SC313_with_4490.txt
    2. SC313_with_patch.txt
  2. I have create a patch file from working copy on top of r4490 (drivedb.h.patch)

Thanks,
Brij

by Brij Kishore Rai, 7 years ago

Attachment: SC313_with_4490.txt​ added

output with r4490

by Brij Kishore Rai, 7 years ago

Attachment: SC313_with_patch.txt​ added

Output with applied patch

comment:7 by Brij Kishore Rai, 7 years ago

Resolution: fixed
Status: closed → reopened

Hi Chris,

I re-opened the ticket and also provided suggested patch. Please help getting this fixed.

Thanks,
Brij

comment:8 by Alex Samorukov, 7 years ago

Thank you for the feedback. 

(.*SK hynix SC.*|"
".*SKhynix SC.*)",

Could be replaces with 

.*SK ?hynix SC.*

But what really makes me unhappy is that if your company will ever release disk with a different SMART but same model name - it will fail. So let me check why original patch was not working.

comment:9 by Alex Samorukov, 7 years ago

Also this patch will break HFS512G32MND model

comment:10 by Brij Kishore Rai, 7 years ago

Hi Chris,

Patch r4490 didn't worked on SC313 drive due to the missing space as 3rd character (space) in the model number. and also it creates a partial match with drives model number.

instead of

"SKhynix SC(300|313)"

it needs to be

"SK hynix SC(300|313).*"

and also can be merged with another string

"SK hynix SC(210|308)|"

as

"SK ?hynix SC(210|300|308|313).*"

and may another concern was all the attribute wherein SK hynix drive differs where not included int r4490 patch.

So, I update my working code based on your suggestion and what I found missing.

Let me know your thought.

Regards,
Brij

by Brij Kishore Rai, 7 years ago

Attachment: drivedb.h.patch​ added

drivedb.h r4490 patch

comment:11 by Christian Franke, 7 years ago

Summary: SK hynix SC313 HFS256G32TNF-N3A0A → SK hynix SC210, SC300, SC308, SC313 HFS256G32TNF-N3A0A
Type: enhancement → patch

Tickets #724 and #792 have been marked as duplicates of this ticket.

comment:12 by Christian Franke, 7 years ago

Resolution: → fixed
Status: reopened → closed

r4500, r4501.

comment:13 by Christian Franke, 16 months ago

Ticket #1661 has been marked as a duplicate of this ticket.

Note: See TracTickets for help on using tickets.