Opened 8 years ago

Closed 8 years ago

#815 closed patch (fixed)

Add options '-g/s dsn' to set/get DSN feature.

Reported by: JonghwanChoi Owned by: Christian Franke
Priority: minor Milestone: Release 6.6
Component: all Version: 6.5
Keywords: Cc:

Description

For supporting enable/disable DSN feature.

Attachments (2)

0001-smartcl-Add-options-g-s-dsn-to-get-set-DSN-feature.patch​ (9.9 KB ) - added by JonghwanChoi 8 years ago.
0001-smartcl-Add-options-g-s-dsn-to-get-set-DSN-feature_new.patch​ (10.8 KB ) - added by JonghwanChoi 8 years ago.
I added the some description "If possible, please also provide a patch which adds some description about the new option and DSN to --get/--set section of smartctl.8.in and a brief description -e section of smartd.conf.5.in."

Download all attachments as: .zip

Change History (6)

by JonghwanChoi, 8 years ago

Attachment: 0001-smartcl-Add-options-g-s-dsn-to-get-set-DSN-feature.patch​ added

comment:1 by Christian Franke, 8 years ago

Component: smartctl → all
Milestone: → Release 6.6
Owner: set to Christian Franke
Status: new → accepted

Thanks for this patch. Looks very good.

If possible, please also provide a patch which adds some description about the new option and DSN to --get/--set section of smartctl.8.in and a brief description -e section of smartd.conf.5.in.

Which real world devices do actually support DSN?

comment:2 by JonghwanChoi, 8 years ago

If possible, please also provide a patch which adds some description about the new option and DSN to --get/--set section of smartctl.8.in and a brief description -e section of smartd.conf.5.in.
-> Let me check and fix.

Which real world devices do actually support DSN?
-> Yep, I tested it with SanDisk SSD.

This patch was developed for testing purposes while developing fw.

thanks

Last edited 8 years ago by JonghwanChoi (previous) (diff)

by JonghwanChoi, 8 years ago

Attachment: 0001-smartcl-Add-options-g-s-dsn-to-get-set-DSN-feature_new.patch​ added

I added the some description "If possible, please also provide a patch which adds some description about the new option and DSN to --get/--set section of smartctl.8.in and a brief description -e section of smartd.conf.5.in."

comment:3 by JonghwanChoi, 8 years ago

Hi
I added a description as requested in 0001-smartcl-Add-options-g-s-dsn-to-get-set-DSN-feature_new.patch​ added.

Please let me know if something goes wrong.

thanks

comment:4 by Christian Franke, 8 years ago

Resolution: → fixed
Status: accepted → closed
Type: enhancement → patch

Patch applied in r4402. Thanks.

Note: See TracTickets for help on using tickets.