Opened 4 years ago

Closed 4 years ago

#1465 closed defect (fixed)

Use of wrong devicename in autodetection unter OpenBSD

Reported by: Martin Ziemer Owned by: Christian Franke
Priority: major Milestone: Release 7.3
Component: all Version: 7.2
Keywords: openbsd Cc:

Description

In os_openbsd.cpp in openbsd_smart_interface::autodetect_smart_device the type is guessed by the devicename. To check this, the devicename is stripped from its path into the variable "test_name".
But for opening and working with the device, the full name is needed (variable "name").

To fix this, the variable "test_name" should be changed to "name" in lines 585, 592 and 595.

Attachments (2)

devicename.patch​ (1.2 KB ) - added by Martin Ziemer 4 years ago.
Changes described in ticket as patch
devicename_and_changelog.patch​ (1.5 KB ) - added by Martin Ziemer 4 years ago.
Forgot to edit changelog! -- Please look at this patch!

Download all attachments as: .zip

Change History (6)

comment:1 by Christian Franke, 4 years ago

Keywords: openbsd added; OpenBSD removed
Milestone: → unscheduled
Priority: minor → major

To fix this, the variable "test_name" should be changed to "name" in lines 585, 592 and 595.

Please provide this as a patch. The patch should also include an addition to the ChangeLog file.

by Martin Ziemer, 4 years ago

Attachment: devicename.patch​ added

Changes described in ticket as patch

by Martin Ziemer, 4 years ago

Attachment: devicename_and_changelog.patch​ added

Forgot to edit changelog! -- Please look at this patch!

comment:2 by Christian Franke, 4 years ago

Milestone: unscheduled → Release 7.3

Looks good, thanks.

comment:3 by Christian Franke, 4 years ago

Owner: set to Christian Franke
Status: new → accepted

comment:4 by Christian Franke, 4 years ago

Resolution: → fixed
Status: accepted → closed

Applied in r5213, thanks.

Note: See TracTickets for help on using tickets.