Bogus smartctl exception on unknown ATA form factor value [regression]

[Christian Franke]

If a drive reports a form factor > 0x9 in ATA IDENTIFY word 168, smartctl 7.0 aborts with a JSON exception even if JSON output mode is not enabled:

smartctl 7.0 2018-12-30 r4883 [Darwin 17.7.0 x86_64] (local build)
Copyright (C) 2002-18, Bruce Allen, Christian Franke, www.smartmontools.org

=== START OF INFORMATION SECTION ===
Model Family:     Marvell based SanDisk SSDs
Device Model:     SanDisk SDSSDHP128G
Firmware Version: X2306RL
User Capacity:    128,035,676,160 bytes [128 GB]
Sector Size:      512 bytes logical/physical
Rotation Rate:    Solid State Device
Form Factor:      Unknown (0x000a)
Smartctl: Exception: json.cpp(121): Assertion failed: value
Please inform smartmontools-support@listi.jpberlin.de, including output
of smartctl -V.

Thanks to Olaf Pokorny for the ​bug report on smartmontools-support mailing list.

This is a serious regression from r4640 as it blocks usage of smartctl with such drives.

[Christian Franke]

Fixed in r4889.