Changes between Initial Version and Version 1 of Ticket #870, comment 5


Ignore:
Timestamp:
Oct 18, 2017, 12:17:40 PM (7 years ago)
Author:
Christian Franke

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #870, comment 5

    initial v1  
    2323- Use of `calloc()` without nullptr check. Use `new` instead or better avoid it at all (see `raw_buffer`).
    2424- Misleading indentation, use of tab characters instead of blanks (see `.editorconfig` file).
    25 - Missing `static` for local functions`
     25- Missing `static` for local functions.
    2626- Unnecessary casts `char []` to `char *`.
    2727- Missing `'\n'` in error message.
    … …  
    2929
    3030
    31 Is is assured that the new code avoids possibly unsupported SCSI commands on (non-WDC or WDC) drives which does not support these ATA-like Attributes?
     31Is is assured that the new code avoids possibly unsupported SCSI commands on (non-WDC or WDC) drives which do not support these ATA-like Attributes?