Opened 8 years ago

Last modified 4 years ago

#820 new task

Would like to contribute to making smartctl a static library

Reported by: Allan Liu Owned by:
Priority: minor Milestone: undecided
Component: all Version: 6.5
Keywords: library Cc:

Description

Hi,

We had a need to utilize smartctl as a library for one of our infrastructure management applications, but didn't seem like one will ever be on the road map, so I made one to get us what we need in the interim. This has proved to be rather useful for us, and we would love to contribute back to the project. However, I didn't really see any place to properly put up a PR so I put one up on the github mirror (​https://github.com/mirror/smartmontools/pull/2). Would love to get some feedback from you guys (and obviously the opportunity to contribute back). Thanks!

  • Allan

Change History (8)

in reply to:  description comment:1 by Christian Franke, 8 years ago

Milestone: → undecided

Thanks for your contribution.

..., but didn't seem like one will ever be on the road map, ...

This is longer true, as I'm working on a more generic approach for a smartmontools API/library. The first draft will be published sometimes after Release 6.6.

This has proved to be rather useful for us, and we would love to contribute back to the project.

Thanks - but sorry, your approach is rather incompatible to my current approach for an API. So it is rejected for now.

However, I didn't really see any place to properly put up a PR so I put one up on the github mirror (​https://github.com/mirror/smartmontools/pull/2).

Please note that this mirror project is independent from smartmontools developers and probably will never accept your pull requests. We still use SVN as upstream repository.

Feel free to create a fork of this mirror and add your changes there. Then I would add this to our Links page.

comment:2 by Allan Liu, 5 years ago

Hi Christian,

Totally forgot to fill you in on this from a couple years ago, but I made a simple lib from the smartmontools fork here: ​https://github.com/allanliu/smartmontools

I'm going to begin work on adding NVMe support soon. Would be great if you could still add this to your links page.

Thanks,

Allan

comment:3 by Christian Franke, 5 years ago

Would be great if you could still add this to your links page.

Of course - see this change of Links page.

BTW: We now have an ​official GitHub mirror.

comment:4 by Allan Liu, 5 years ago

Awesome! Thanks Christian!

comment:5 by Anatol, 5 years ago

Thank you Allan for your work.

osquery project uses Allan's smartmontools library. It would be great to see his work get upstreamed (or something similar implemented from the scratch) to avoid having duplicated packages for the smartmontools forks.

Christian, do you have any progress with the library implementation?

in reply to:  5 comment:6 by Christian Franke, 5 years ago

Christian, do you have any progress with the library implementation?

Progress: yes - Ready to publish: no. We possibly have this in Release 8.0 or so :-)

comment:7 by J.R. Heisey, 5 years ago

I wanted to promote the release of the library. I would have used it if available.

comment:8 by Christian Franke, 4 years ago

Ticket #1367 has been marked as a duplicate of this ticket.

Note: See TracTickets for help on using tickets.