Opened 12 years ago

Closed 12 years ago

#266 closed patch (fixed)

Warnings os_darwin.cpp: -Wself-assign

Reported by: gecko2 Owned by: Christian Franke
Priority: minor Milestone: Release 6.2
Component: smartd Version: 6.0
Keywords: macosx Cc:

Description

During compilation i get severel -Wself-sign warnings in os_darwin.cpp on MacOSX.

The attached patch fixes those warnings.

The patch works with 6.0 and 6.1.

Attachments (2)

smartmontools.patch​ (3.0 KB ) - added by gecko2 12 years ago.
smartmontools-os_darwin.cpp-2.patch​ (1.9 KB ) - added by Christian Franke 12 years ago.
Patch version 2

Download all attachments as: .zip

Change History (7)

by gecko2, 12 years ago

Attachment: smartmontools.patch​ added

comment:1 by gecko2, 12 years ago

Keywords: macosx added

Add Keywords

comment:2 by Christian Franke, 12 years ago

Milestone: → Release 6.2
Owner: changed from somebody to Christian Franke
Status: new → accepted

by Christian Franke, 12 years ago

Attachment: smartmontools-os_darwin.cpp-2.patch​ added

Patch version 2

comment:3 by Christian Franke, 12 years ago

Please test the attached new patch version. It uses the traditional C++ way to specify unused parameters and removes the dummy functions no longer called since r3192.

comment:4 by gecko2, 12 years ago

The patch works and no more warnings where issued.

comment:5 by Christian Franke, 12 years ago

Resolution: → fixed
Status: accepted → closed

r3805.

Note: See TracTickets for help on using tickets.