Opened 13 years ago

Closed 13 years ago

#194 closed patch (fixed)

little tweaks to the systemd service file

Reported by: mstapelberg Owned by: Christian Franke
Priority: minor Milestone: Release 5.43
Component: smartd Version:
Keywords: Cc:

Description

I have the following little tweaks to the systemd service file:

  1. Add ExecReload= to make systemctl reload smartd.service work as expected
  2. Make stdout go to syslog by default.
  3. Remove the EnvironmentFile= line completely. The rationale here is that local adjustments to the smartd command line can be made by copying the service file to /etc/systemd. The best way of course would be to make all these parameters work via /etc/smartd.conf so that init would not have to do anything with this.

If you disagree with me on 3., at least use EnvironmentFile=-/etc/sysconfig/smartmontools, so that systemd does not fail to start the file when /etc/sysconfig/smartmontools is not present.

Attachments (1)

smartd.service.in.patch​ (411 bytes ) - added by mstapelberg 13 years ago.
Patch which adds ExecReload=, StandardOutput=

Download all attachments as: .zip

Change History (4)

by mstapelberg, 13 years ago

Attachment: smartd.service.in.patch​ added

Patch which adds ExecReload=, StandardOutput=

comment:1 by Christian Franke, 13 years ago

Component: all → smartd
Milestone: → Release 5.43

comment:2 by Christian Franke, 13 years ago

Owner: changed from somebody to Christian Franke
Status: new → accepted

comment:3 by Christian Franke, 13 years ago

Resolution: → fixed
Status: accepted → closed

r3560. EnvironmentFile now optional as suggested above. Please test if possible.

Note: See TracTickets for help on using tickets.