#1472 closed defect (fixed)
HP Smart Array connected disk don't need -d cciss,N when in HBA mode
Reported by: | Phillip Schichtel | Owned by: | Christian Franke |
---|---|---|---|
Priority: | minor | Milestone: | Release 7.3 |
Component: | all | Version: | 7.2 |
Keywords: | cciss linux | Cc: | steffen.wagner@… |
Description
Hi everyone!
I'm operating a Ceph cluster on a set of HP servers, where the Smart Array controller is configured in HBA mode, so Ceph has full control over the individual disks, which works perfectly fine.
I noticed however, that smartctl as executed by ceph fails to collect the SMART data and complains e.g. "/dev/sda: requires option '-d cciss,N'". This would be correct if the device was part of a RAID managed by the HPSA controller, but it's not.
I looked at the code and in os_linux.c the function is_hpsa(device) is used to as the only condition for this error message without considering, that the device might not be part of a RAID.
Attachments (1)
Change History (7)
comment:1 by , 4 years ago
Component: | smartctl → all |
---|---|
Keywords: | linux added; hpsa removed |
by , 4 years ago
Attachment: | hpsa-respect-hba-mode-1472.patch added |
---|
This patch changes the is_hspa(name) function to the is_hspa_in_raid_mode(name) function and checks the raid_level disk attribute for value "N/A", which is used by the kernel module for drives that are not logical: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/scsi/hpsa.c?id=6417f03132a6952cd17ddd8eaddbac92b61b17e0#n693
comment:5 by , 4 years ago
Not sure what the typical process is: When would this release and will it be backported to older versions (and if so, by whom) ?
comment:6 by , 4 years ago
We are a very small team of volunteers maintaining smartmontools in unpaid spare time. We usually provide one release each year. Only critical patches are backported to the previous release.
Patch looks good, thanks. Please also include a ChangeLog entry (email address optional) and add the following:
PS: Please do not set the Milestone in future submissions.